cvs commit: src/sys/fs/nullfs null_vfsops.c src/sys/fs/nwfs nwfs_vfsops.c src/sys/fs/smbfs smbfs_vfsops.c src/sys/ufs/ufs quota.h ufs_quota.c ufs_vfsops.c src/sys/kern vfs_default.c vfs_vnops.c vnode_if.src src/sys/sys mount.h vnode.h

[Dag-Erling Smørgrav]

Robert Watson <rwatson at FreeBSD.org> writes:
> Dag-Erling Smørgrav <des at des.no> writes:
> > No, it changes neither the API nor the ABI.  It replaces caddr_t
> > (which is typedef'd to char *) with void *, and those two are
> > compatible types.
> I'm sorry, but I disagree.  The case you failed to test involves a
> function pointer typedef.

Umm, OK, I didn't spot that.  It's unfortunate that David didn't change
our own file system code to match (or even build LINT, which would have
shown him the problem), so that RELENG_6 current doesn't build.

Still, I would argue for fixing the code rather than reverting the
change.

> Here's the test I had to add to Arla to detect the change with
> autoconf; without this autoconf mess and changed prototypes in the
> Arla nnpfs code, I can't build nnpfs on -CURRENT, and presumably now
> also on our -STABLE branches:

Arguably, Arla has been broken for more than two years and you only just
woke up and noticed.  If you had tried to build Arla on -CURRENT at any
point since 2005/12/14, you would have noticed and presumably fixed it.

DES
-- 
Dag-Erling Smørgrav - des at des.no