cvs commit: src/sys/ufs/ffs ffs_alloc.c ffs_balloc.c ffs_inode.c ffs_snapshot.c ffs_softdep.c ffs_vnops.c src/sys/ufs/ufs ufs_bmap.c ufs_lookup.c ufs_vnops.c

[David O'Brien]

On Mon, Feb 25, 2008 at 11:34:49AM +0100, Kris Kennaway wrote:
> David E. O'Brien wrote:
>> obrien      2008-02-25 06:30:24 UTC
>>   FreeBSD src repository
>>   Modified files:        (Branch: RELENG_6)
>>     sys/ufs/ffs          ffs_alloc.c ffs_balloc.c ffs_inode.c              
>>             ffs_snapshot.c ffs_softdep.c ffs_vnops.c     sys/ufs/ufs       
>>    ufs_bmap.c ufs_lookup.c ufs_vnops.c   Log:
>>   MFC: Turn most ffs 'DIAGNOSTIC's into INVARIANTS.
> 
> Didn't we (you, Ken and I) discuss that this is not a good merge
> candidate because of the possibility to introduce further spurious
> panics into a stable branch?

We agreed to let it soak for a good while.  We have not seen any new
issues for several months.  I think finding file system errors out weight
the risks due to any remaining buglets.  If one has enabled INVARIANTS,
they want to find problems in their system.

-- David