cvs commit: src/sys/kern uipc_syscalls.c

[Robert Watson]

On Sun, 24 Feb 2008, Andre Oppermann wrote:

>>>  After finishing sending file data in sendfile(2), don't forget to send
>>>  the provided trailers.  This has been broken since revision 1.240.
>> 
>> Nice work tracking this down -- it sounds like the perfect candidate for a 
>> regression test.  Over the last year or two, we've been working hard to 
>> populate src/tools/regression/sockets with various test cases, and it 
>> sounds like the sendfile tests there could use some fleshing out, since 
>> we've now seen several rather significant functional regressions over the 
>> last few years.  Any chance we can get you to take a look at doing that as 
>> well? :-)
>
> Writing a regression test should be my task as I'm the one who broke the

That would be really great, thanks!  Make sure to add a protocol switch/loop 
somewhere so that the tests are run over UNIX domain sockets and SCTP, not 
just for TCP on IPv4 and IPv6.  I suspect sendfile() on non-TCP sockets 
doesn't see a whole lot of use, but needs to be exercised also.  Certainly 
SCTP will see a lot more use in the future.

Robert N M Watson
Computer Laboratory
University of Cambridge