cvs commit: src/sbin/mount_nfs mount_nfs.c

[Yar Tikhiy]

On Mon, Feb 18, 2008 at 10:37:36AM +0000, Craig Rodrigues wrote:
> On Mon, Feb 18, 2008 at 10:24:48AM +0000, Yar Tikhiy wrote:
> >   The real solution would be to bring the whole nmount(2)
> >   framework, including FS drivers and userland tools, into
> >   a consistent state at last; but things should work in the
> >   meantime, too.
> 
> When I read comments like this, I have the feeling
> that you are doing drive-by-commits to areas where you do
> not understand the full implications of what you are doing.

I'll pray for your understanding to be better than mine.

> Can you slow down on your commits to the mount code, and try
> to post more of your patches to mailing lists so other people
> can review them and try them out?  You've indicated to me
> that you don't have time to fully test out and implement the
> necessary changes to fix all the file systems and userland code
> in FreeBSD related to mounting file systems.

I have no more commits pending in my queue.

> While I appreciate your efforts to deal with PR's and fix things,
> the mount code is a tangled web, and it is very easy to introduce
> subtle errors in unrelated areas by committing what appear
> to be "obvious fixes".  This has happened to a few people (including
> me) in the past.

Indeed, all our sins are recorded in the CVS history. ;-)

-- 
Yar