cvs commit: src/sys/sys lockmgr.h

Attilio Rao attilio at freebsd.org
Sun Feb 10 06:41:29 PST 2008


2008/2/10, Robert Watson <rwatson at freebsd.org>:
>
>  On Sun, 10 Feb 2008, Attilio Rao wrote:
>
>  >> > I think this shall be MFCed to RELENG_7 and RELENG_7_0.
>  >>
>  >> ... once it no longer breaks the tinderbox?
>  >>
>  >> BTW, at this point 7.0 is basically closed to any further changes.  Anyone
>  >> planning on getting things in to 7.x needs to be thinking about either
>  >> errata notices (for really critical things) and 7.1.
>  >
>  > Buh! I'm very sorry for this. Really, this needed to be better croaked. It
>  > needs to include sys/lock.h for any lockmgr.h consumer (making lock.h a
>  > pre-requirement in lockmgr usage). This is going to be a little bit of work.
>  >
>  > For the moment I will revert this change, doing a better stub later, once
>  > other details about lockmgr are refined.
>
>
> Or temporarily nested include lock.h from lockmgr.h.  I'm pretty sure that all
>  consumers of struct lock pretty much include _lock.h, so if there's a
>  widespread dependency you could also move whatever the definitions are to
>  _lock.h.

As long as this is also temporary code, I would prefer to move lock.h
into lockmgr.h as solution.
I don't want to touch _lock.h as traditionally (about all the other
locking primitives too) this only includes structures definition and
related macros (which has nothing to do with this specific problem).

Attilio


-- 
Peace can only be achieved by understanding - A. Einstein


More information about the cvs-src mailing list