cvs commit: src/sbin/mount mount.c

[Niki Denev]

On Feb 3, 2008 8:31 PM, Matteo Riondato <matteo at freebsd.org> wrote:
> On Sun, Feb 03, 2008 at 07:54:28PM +0200, Niki Denev wrote:
> > mount(8) has also "-p" option problems with gjournal-ed filesystems.
> > The same problems prevents mount updates with option "current" too,
> > i.e. "mount -u -ocurrent,noatime /gjournaledfs"
> > Here is a PR about this : http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/120162
>
> Err, reply to self:
> The problem with -ocurrent still exists, while the problem with -p is
> gone.
> I'll try to work on it, thanks.
>
> --
> Matteo Riondato
> FreeBSD Committer (http://www.FreeBSD.org)
> FreeSBIE Developer (http://www.FreeSBIE.org)
> GUFI Staff Member (http://www.GUFI.org)
>

Hi,

I'm running with version 1.96 of mount.c and both problems still exist :

  server# mount -p | grep journal
  /dev/da0p2.journal      /                       ufs
async,noatime,gjournal  1 1

  server# mount -u -oatime,current /
  mount: mount option <gjour : Invalid argument

With the patch that I supplied in the PR the behaviour looks correct :

  server# mount -p | grep journal
  /dev/da0p2.journal      /                       ufs     async,noatime   1 1

  server# mount -u -o current,atime /
  server# mount -p | grep journal
  /dev/da0p2.journal      /                       ufs     async           1 1


--Niki