cvs commit: src/etc/periodic/security 100.chksetuid

[Simon L. Nielsen]

On 2008.02.02 19:33:44 +0000, Ceri Davies wrote:
> On Sat, Feb 02, 2008 at 05:52:15PM +0100, Hartmut Brandt wrote:
> > Simon L. Nielsen wrote:
> >> On 2008.02.02 14:53:21 +0000, Ceri Davies wrote:
> >>> On Sat, Feb 02, 2008 at 12:27:38PM +0000, Dag-Erling Smorgrav wrote:
> >>>> des         2008-02-02 12:27:38 UTC
> >>>> 
> >>>>   FreeBSD src repository
> >>>> 
> >>>>   Modified files:
> >>>>     etc/periodic/security 100.chksetuid   Log:
> >>>>   Rewrite to consume significantly less memory, by using find -s instead of
> >>>>   find | sort.  As a bonus, this simplifies the logic considerably.  Also
> >>>>   remove the bogus "overruning the args to ls" comment and the corresponding
> >>>>   "-n 20" argument to xargs; the whole point with xargs is precisely that it
> >>>>   knows how large the argument list can safely get.
> >>> Why use xargs at all?  The "-exec ls -liTd {} +" primary would do the
> >>> same thing.
> >> 
> >> You would end up executing ls a lot more times with the extra overhead
> >> for fork() etc. per file.
> > 
> > I think "-exec ... {} +" collects as much arguments before executing just 
> > as xargs does. This is different from "-exec ... {} ;" which execs for each 
> > argument.
> 
> Exactly my point, yes.

I have never sumbled onto the "+" version only ";" so I just read it as ";".

You (hopefully) learn something new everyday :-).

-- 
Simon L. Nielsen