cvs commit: src ObsoleteFiles.inc src/libexec Makefile src/libexec/pt_chown Makefile pt_chown.c

[Ed Schouten]

ed          2008-08-24 10:01:22 UTC

  FreeBSD src repository

  Modified files:
    .                    ObsoleteFiles.inc 
    libexec              Makefile 
  Removed files:
    libexec/pt_chown     Makefile pt_chown.c 
  Log:
  SVN rev 182105 on 2008-08-24 10:01:22Z by ed
  
  Remove the now unneeded pt_chown utility.
  
  Before we had a posix_openpt() that allocated PTY's with proper
  permissions in place, we used this set-uid utility to change the
  ownership of PTY slave devices to the real user ID of the process. This
  utility was used to implement grantpt().
  
  In my first designs of the MPSAFE TTY layer, I replaced this by adding
  an ioctl() called TIOCGRANTPT, which was used to change the ownership.
  I left the pt_chown utility, because older C libraries needed it to work
  properly.
  
  After some discussions back in June I changed the PTY code to set
  permissions properly upon creation. Fortunately the previous grantpt()
  implementation changed permissions by hand when pt_chown is not
  installed, which always succeeds. This means grantpt() still works
  properly, even though the set-uid utility is missing.
  
  I've done tests with FreeBSD 5.2.1, FreeBSD 6.3 and FreeBSD 7.0 jails.
  All of them still work if I remove pt_chown.
  
  Reviewed by:    philip (ex-mentor)
  
  Revision  Changes    Path
  1.156     +2 -0      src/ObsoleteFiles.inc
  1.79      +0 -1      src/libexec/Makefile
  1.5       +0 -8      src/libexec/pt_chown/Makefile (dead)
  1.2       +0 -103    src/libexec/pt_chown/pt_chown.c (dead)