cvs commit: src/sys/fs/unionfs union_subr.c

[Robert Watson]

On Fri, 25 Apr 2008, Daichi GOTO wrote:

> daichi      2008-04-25 09:53:52 UTC
>
>  FreeBSD src repository
>
>  Modified files:
>    sys/fs/unionfs       union_subr.c
>  Log:
>  o Improved unix socket connection issue
>    fixed: kern/118346
>
>  PR:             kern/118346
>  Submitted by:   Masanori OZAWA (ozawa at ongs.co.jp)
>  MFC after:      1 week

Goto-san,

Per my earlier e-mail, and assuming I understand correctly, I feel not only 
will this lead to new panics (due to dangling socket pointers and incomplete 
garbage collection), but it will also lead to possibly incorrect semantics for 
unionfs (upper layers can write to objects readable via the lower layer). 
Some parts of this patch are fine, but the copying of v_socket pointers 
between layers is not correct.  Please consider backing that part of the 
change out.

Thanks,

Robert N M Watson
Computer Laboratory
University of Cambridge