cvs commit: src/sys/boot/common dev_net.c src/sys/boot/uboot/lib console.c copy.c glue.c libuboot.h net.c time.c

[Marcel Moolenaar]

On Apr 16, 2008, at 4:07 AM, Rafal Jaworowski wrote:
>> On at least sparc64 reverting this causes ofwn_init() to be called
>> over and over again, which doesn't seem to be the right thing to do
>> either.
>
> I think this is expected: the loader/libstand seem to call
> devopen()->net_open(), devclose()->net_close() upon each file  
> access, but it
> doesn't seem harmful, only additional output is seen in this case.

The additional output is still an eyesore :-)

Your change is correct, but it does expose a more fundamental
problem with the loader for which we may not have the gumption
to fix (as demonstrated by revision 1.7). The bottom-line being
that we should not open and close devices wishy-washy.

-- 
Marcel Moolenaar
xcllnt at mac.com