cvs commit: src/sys/dev/re if_re.c src/sys/pci if_rlreg.h

[Pyun YongHyeon]

On Mon, Apr 14, 2008 at 07:35:04PM +0200, Remko Lodder wrote:
 > Pyun YongHyeon wrote:
 > >On Wed, Apr 09, 2008 at 12:34:01PM -0700, Abdullah Ibn Hamad Al-Marri 
 > >wrote:
 > > > ----- Original Message ----
 > > > > From: Pyun YongHyeon <yongari at FreeBSD.org>
 > > > > To: src-committers at FreeBSD.org; cvs-src at FreeBSD.org; 
 > > cvs-all at FreeBSD.org
 > > > > Sent: Monday, March 31, 2008 7:03:14 AM
 > > > > Subject: cvs commit: src/sys/dev/re if_re.c src/sys/pci if_rlreg.h
 > > > > 
 > > > > yongari     2008-03-31 04:03:14 UTC
 > > > > 
 > > > >   FreeBSD src repository
 > > > > 
 > > > >   Modified files:
 > > > >     sys/dev/re           if_re.c 
 > > > >     sys/pci              if_rlreg.h 
 > > > >   Log:
 > > > >   Padding more bytes than necessary one broke another variants of
 > > > >   PCIe RealTek chips. Only pad IP packets if the payload is less than
 > > > >   28 bytes.
 > > > >   
 > > > >   Obtained from:  NetBSD
 > > > >   PR:             kern/122221
 > > > >   
 > > > >   Revision  Changes    Path
 > > > >   1.113     +1 -1      src/sys/dev/re/if_re.c
 > > > >   1.74      +6 -0      src/sys/pci/if_rlreg.h
 > > > 
 > > > Hello Pyun,
 > > > 
 > > > I hope you are doing well.
 > > > 
 > > > This is a friendly reminder...
 > > > 
 > > > It has been more than a week since you said you'll MFC the re changes 
 > > to RELENG_7
 > > > 
 > > > I still suffer of the current patch and the re poor performance.
 > > > 
 > > > Thank you in advance,
 > > > 
 > >
 > >There was one regression report from remko so we are testing a patch.
 > >It seems that the regression is hard to reproduce at will it may
 > >take more time. I'll MFC all changes to RELENG_7 as soon as he say Ok.
 > >
 > >Thanks for remiding this!
 > 
 > Hi all,
 > 
 > I think Pyun can MFC the changes where needed  / possible because I 
 > couldn't trigger it so far. Last time it took me several days to get
 > the machine down, so one never knows when I can reproduce it again. I
 > am getting a new (Second) machine to test this with somewhere this week
 > so that I can 'dedicatedly' test the patch and try to reproduce it even
 > quicker :-)
 > 
 > That said; I think the changes made by pyun are a substantial 
 > improvement nevertheless and should (Where possible) not be withheld 
 > from people :)
 > 
 > Pyun please process this when possible :-)
 > 

First, I'll commit the patch you tested and wait a couple of days
before MFCing re(4) to RELENG_7.

Thanks for all your hardwork and continuous support!

-- 
Regards,
Pyun YongHyeon