cvs commit: src/bin/ls ls.1 ls.c ls.h print.c

[Greg 'groggy' Lehey]

On Saturday,  5 April 2008 at 20:41:44 -0400, Coleman Kane wrote:
> Greg 'groggy' Lehey wrote:
>> On Saturday,  5 April 2008 at 19:40:02 +0000, Bjoern A. Zeeb wrote:
>>
>>> On Fri, 4 Apr 2008, Greg Lehey wrote:
>>>
>>>
>>>> grog        2008-04-04 03:57:47 UTC
>>>>
>>>> FreeBSD src repository
>>>>
>>>> Modified files:
>>>>  bin/ls               ls.1 ls.c ls.h print.c
>>>> Log:
>>>> Add -D option to specify exact format of date and time output with ls -l.
>>>>
>>> I think something went wrong here. Could you please fix this. Thanks.
>>>
>>> bz at dopt:/local/building/freebsd/HEAD/bin/ls> ll
>>> total 80
>>> drwxr-xr-x  2 bz  wheel    512 Apr  5 15:18 CVS/
>>> -rw-r--r--  1 bz  wheel    300 May 25    2004 Makefile
>>> -rw-r--r--  1 bz  wheel   4803 Mar 24    2006 cmp.c
>>> -rw-r--r--  1 bz  wheel   2852 Mar 24    2006 extern.h
>>>
>>
>> Ugh.  My editor was a little too zealous in replacing spaces with tabs :-(
>
> Uhm.... shouldn't this be "\t" instead of the actualy tab character
> (0x08)?

No.  It should be two spaces.

Here's the diff :-)

--- print.c     4 Apr 2008 03:57:46 -0000       1.77
+++ print.c     5 Apr 2008 23:44:24 -0000
@@ -388,7 +388,7 @@
                format = d_first ? "%e %b %R" : "%b %e %R";
        else
                /* mmm dd  yyyy || dd mmm  yyyy */
-               format = d_first ? "%e %b  %Y" : "%b %e  %Y";
+               format = d_first ? "%e %b  %Y" : "%b %e  %Y";
        strftime(longstring, sizeof(longstring), format, localtime(&ftime));

For reasons lost in the mists of time, there are two spaces before the
%Y in this format, but my editor accidentally replaced them with a tab
character.  As you can see, that's not immediately obvious.

Greg
--
See complete headers for address and phone numbers.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080406/a5f97d8b/attachment.pgp