cvs commit: src/games/fortune/datfiles fortunes

[Yar Tikhiy]

On Mon, Mar 31, 2008 at 11:19 PM, Doug Barton <dougb at freebsd.org> wrote:
>
> Ganbold Tsagaankhuu wrote:
>  > ganbold     2008-03-31 10:28:09 UTC
>  >
>  >   FreeBSD src repository (doc committer)
>  >
>  >   Modified files:
>  >     games/fortune/datfiles fortunes
>  >   Log:
>  >   Improve some quotes of Chinggis Khan.
>  >   Remove militant and moralized quotes of Chinggis Khan.
>  >   Add one more quote of Chinggis Khan.
>  >
>  >   Reviewed by: yar
>  >   Approved by: keramida(mentor)
>  >
>  >   Revision  Changes    Path
>  >   1.259     +37 -56    src/games/fortune/datfiles/fortunes
>  >
>  > http://www.FreeBSD.org/cgi/cvsweb.cgi/src/games/fortune/datfiles/fortunes.diff?&r1=1.258&r2=1.259&f=h
>
>  We do not remove fortunes without a very good reason. Can you please
>  replace the ones you deleted?

Please note that the fortunes removed were submitted by Ganbold some
time ago. The things went as follows:

- Ganbold posted a PR on adding quotes from Chinggis Khan;
- the original version of the quotes was in rather poor English;
- grog@ committed the patch as is without any corrections and left it to rot;
- now Ganbold has got his commit bit and wants to finish the task he
initially suggested.

So I think Ganbold in a way owns the quotes and it's up to him to
decide what final cut of Chinggis Khan's wisdom to present to the
English-speaking world. Due to poor quality of grog@'s initial commit
(which raised no objections BTW), the quotes had been WIP before this
commit. IMHO this commit isn't covered by the "don't remove fortunes"
rule.

-- 
Yar