cvs commit: src/bin/getfacl getfacl.c

[Henrik Brix Andersen]

On Fri, Sep 21, 2007 at 01:17:27PM +0800, Kevin Lo wrote:
> Henrik Brix Andersen wrote:
> > On Wed, Sep 19, 2007 at 02:04:47AM +0000, Kevin Lo wrote:
> > > kevlo       2007-09-19 02:04:47 UTC
> > > 
> > >   FreeBSD src repository
> > > 
> > >   Modified files:
> > >     bin/getfacl          getfacl.c 
> > >   Log:
> > >   Use owner name and owning group name instead of uid and gid
> > >   for displaying the three-line comment header by default.
> > >   
> > >   Reviewed by: kientzle
> > >   Approved by: re (bmah)
> > 
> > Isn't this a POLA violation? At least I think it should be mentioned
> > in UPDATING as people might (I know I do) have scripts, that actually
> > parse the uid/gid fields in the header.
> 
> How about adding a "-n" option to display user and group IDs 
> numerically? thoughts?

That may be overkill... As far as I am concerned, a simple entry in
UPDATING is sufficient. Here's my suggested patch:


--- /usr/src/UPDATING	2007-07-09 11:11:19.000000000 +0200
+++ UPDATING	2007-09-21 13:50:33.000000000 +0200
@@ -21,6 +21,12 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 7.
 	developers choose to disable these features on build machines
 	to maximize performance.
 
+20070921:
+	The getfacl(1) utility now prints owning user and group name
+	instead of owning uid and gid in the three line comment
+	header. This is the same behavior as getfacl(1) on Solaris and
+	Linux.
+
 20070704:
         The new IPsec code is now compiled in using the IPSEC option.  The
 	IPSEC option now requires "device crypto" be defined in your kernel

Regards,
Brix
-- 
Henrik Brix Andersen <henrik at brixandersen.dk>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 209 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20070921/2c8bfd6b/attachment.pgp