cvs commit: src/sys/netinet tcp_subr.c tcp_timer.c tcp_timer.h tcp_usrreq.c tcp_var.h

[Robert Watson]

rwatson     2007-09-07 09:19:23 UTC

  FreeBSD src repository

  Modified files:
    sys/netinet          tcp_subr.c tcp_timer.c tcp_timer.h 
                         tcp_usrreq.c tcp_var.h 
  Log:
  Back out tcp_timer.c:1.93 and associated changes that reimplemented the many
  TCP timers as a single timer, but retain the API changes necessary to
  reintroduce this change.  This will back out the source of at least two
  reported problems: lock leaks in certain timer edge cases, and TCP timers
  continuing to fire after a connection has closed (a bug previously fixed and
  then reintroduced with the timer rewrite).
  
  In a follow-up commit, some minor restylings and comment changes performed
  after the TCP timer rewrite will be reapplied, and a further change to allow
  the TCP timer rewrite to be added back without disturbing the ABI.  The new
  design is believed to be a good thing, but the outstanding issues are
  leading to significant stability/correctness problems that are holding
  up 7.0.
  
  This patch was generated by silby, but is being committed by proxy due to
  poor network connectivity for silby this week.
  
  Approved by:    re (kensmith)
  Submitted by:   silby
  Tested by:      rwatson, kris
  Problems reported by:   peter, kris, others
  
  Revision  Changes    Path
  1.297     +12 -12    src/sys/netinet/tcp_subr.c
  1.96      +242 -306  src/sys/netinet/tcp_timer.c
  1.38      +5 -10     src/sys/netinet/tcp_timer.h
  1.161     +4 -7      src/sys/netinet/tcp_usrreq.c
  1.156     +5 -1      src/sys/netinet/tcp_var.h