cvs commit: src/lib/libc/locale utf8.c

Andrey Chernov ache at nagual.pp.ru
Wed Oct 31 14:51:55 PDT 2007


On Wed, Oct 31, 2007 at 09:41:13PM +1100, Bruce Evans wrote:
> Now the limit is spelled 128, so it really is constant and won't cause
> problems unless the constant changes.

Only in one particular case, the rest cases still need __mb_sb_limit.

> _ctype.h still declares __mb_sb_limit but now doesn't use it.

Do you mean 6x _ctype.h? 8x _ctype.h uses it.

> __mb_sb_limit is still initialized in many files in libc/locale.  These
> initializations now seem to be unused.  Some of them are to 256, so why
> is the constant only 128?

As I already say, there is 3 cases left where it is non-constant.

> __mb_sb_limit is still in Symbol.map.  I think this would be needed if
> __mb_sb_limit were actually used (since although it is now private to
> the library, it would be part of an inter-library ABI if it were used).

It is actually used (for __sbmaskrune, __sbtoupper and __sbtolower).

-- 
http://ache.pp.ru/


More information about the cvs-src mailing list