cvs commit: src/lib/libc/locale utf8.c

Scott Long scottl at samsco.org
Fri Oct 26 12:22:26 PDT 2007


Andrey Chernov wrote:
> On Sat, Oct 27, 2007 at 12:54:21AM +0800, Rong-en Fan wrote:
>> As for RELENG_7 and HEAD, I'm not 100% sure whether we should restore
>> the compatibility as 1) 7.0 is not released yet, 2) we don't promise
>> anything in
>> HEAD branch. However, if most people think get rid of inline stuffs and
>> have libc compatibility are nice, then we do the same for those two branches.
> 
> Although standard permits functions only, I object against permanent 
> removing inlines from ctype. Almost every system have them as macros or 
> inlines and not as function calls, and it is for reason. Ctype functions 
> are very inside-loop-intensive, and not speeding them up may slowdown apps 
> which do intensive text processing.
> 
> In the case we trade forward compatibility for speed for 6x, may be, I 
> don't have opinion here.
> 

RELENG_6 is what I'm most concerned about, so thank you for compromising 
on it.  It's unfortunate that turmoil was created in HEAD and RELENG_7, 
but it looks like it was unavoidable given our standard practices of MFC
oriented changes.  I do think that this all could have been planned and
executed better so that surprises and changes like this weren't needed.
But, live and learn.  Thanks for working on it.

Scott



More information about the cvs-src mailing list