cvs commit: src/sys/dev/ata atapi-cd.c atapi-cd.h

[Scott Long]

M. Warner Losh wrote:
> In message: <473DC220.6030809 at samsco.org>
>             Scott Long <scottl at samsco.org> writes:
> : SXren Schmidt wrote:
> : > sos         2007-10-26 08:59:24 UTC
> : > 
> : >   FreeBSD src repository
> : > 
> : >   Modified files:
> : >     sys/dev/ata          atapi-cd.c atapi-cd.h 
> : >   Log:
> : >   Update the way we get the mode pages on probe.
> : >   
> : >   Revision  Changes    Path
> : >   1.194     +22 -25    src/sys/dev/ata/atapi-cd.c
> : >   1.47      +1 -0      src/sys/dev/ata/atapi-cd.h
> : 
> : Just curious, what was the motivation for changing from doing a
> : TUR to doing a MODE_SENSE in g_access?  Your new code now relies
> : on what I'd consider is a fairly obscure feature of the SFF-8020i
> : spec, and one that contradicts the MMC and SPC specs that are now
> : used as the normative references for packet commands.  There's at
> : least once case, the virtual CDROM emulator in Parallels, that
> : appears not to support this feature, and I'd bet pretty heavily
> : that there are a number of real devices that won't support it
> : either.
> 
> QEMU also has issues.
> 

And I believe there are recent reports on the mailing lists of real
hardware having problems.

Scott