cvs commit: src/sys/i386/bios apm.c

[Warner Losh]

From: Kris Kennaway <kris at FreeBSD.org>
Subject: Re: cvs commit: src/sys/i386/bios apm.c
Date: Wed, 14 Nov 2007 11:01:32 +0100

> Julian Elischer wrote:
> > julian      2007-11-14 05:43:55 UTC
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     sys/i386/bios        apm.c 
> >   Log:
> >   Apply the same sort of locking done in
> >      sys/dev/acpica/acpi.c rev 1.196 a while ago:
> >   
> >   Grab Giant around calls to DEVICE_SUSPEND/RESUME in
> >   acpi_SetSleepState().
> >   If we are resuming non-MPSAFE drivers, they need Giant held for them.
> >   This may fix some obscure suspend/resume problems.  It has fixed keyrate
> >   setting problems that were triggered by cardbus (MPSAFE) changing the
> >   ordering for syscons resume (non-MPSAFE).  Also, add some asserts that
> >   Giant is held in our suspend/resume and shutdown methods.
> >   
> >   Submitted by: Marko Zec
> >   
> >   Revision  Changes    Path
> >   1.149     +10 -0     src/sys/i386/bios/apm.c
> 
> Why are we adding new unconditional giant acquisitions to the tree? 
> Devices indicate whether or not they are mpsafe, why can't this be made 
> conditional?

Because newbus isn't yet mp safe.

Warner