cvs commit: src/sbin/route route.c

[Mike Makonnen]

On Wed, 2007-10-31 at 23:41 +1100, Bruce Evans wrote:
> On Tue, 30 Oct 2007, Giorgos Keramidas wrote:
> 
> > On 2007-10-29 00:08, Mike Makonnen <mtm at freebsd.org> wrote:
> >> mtm         2007-10-29 00:08:24 UTC
> >>
> >>   FreeBSD src repository
> >>
> >>   Modified files:
> >>     sbin/route           route.c
> >>   Log:
> >>   Fix an error in bit shifting logic for network addresses. The route
> >>   command would add incorrect routing entries if network numbers weren't
> >>   fully "spelled" out according to their class. For example:
> >>     # route add 128.0/16   (works)
> >>     # route add 128/16     (doesn't work)
> 
> Isn't this supposed to be handled by inet_net_pton(3)?
> 

Yes, but the way the route(8) code is structured makes it a not minor
surgery. So, I opted for just fixing the bug than implementing it
properly.

Cheers.
-- 
Mike Makonnen         | GPG-KEY: http://people.freebsd.org/~mtm/mtm.asc
mmakonnen @ gmail.com | AC7B 5672 2D11 F4D0 EBF8 5279 5359 2B82 7CD4 1F55
mtm @ FreeBSD.Org     | FreeBSD - http://www.freebsd.org