cvs commit: src/sys/dev/hptmv ioctl.c

mjacob at freebsd.org mjacob at freebsd.org
Mon May 21 04:25:51 UTC 2007


>> mjacob      2007-05-20 16:49:10 UTC
>>
>>  FreeBSD src repository
>>
>>  Modified files:
>>    sys/dev/hptmv        ioctl.c
>>  Log:
>>  Make gcc 4.2 happy by initiatlizing controller && channel prior
>>  to a call to a function which *might* then initialize them.
>>
>>  MFC after:      3 days
>
> Isn't the bug that the function doesn't always initialize them?
>
> Bruce
>

That was a meta-comment- I should have made it clearer. The function 
get_disk_location *will* always init them, but gcc-4.2 doesn't know 
that, and unlike previous versions of gcc, gcc-4.2 no longer will assume 
that a function that you pass a pointer to local data to will actually 
fill them in.

-matt



More information about the cvs-src mailing list