cvs commit: src Makefile.inc1

[Alexander Leidinger]

Quoting Dag-Erling Smorgrav <des at FreeBSD.org> (from Sun, 13 May 2007  
18:15:50 +0000 (UTC)):

> des         2007-05-13 18:15:50 UTC
>
>   FreeBSD src repository
>
>   Modified files:
>     .                    Makefile.inc1
>   Log:
>   Greatly speed up {check,delete}-old* by replacing make loops with sh loops.

How much faster? Thanks for tackling this.

Some review:

Why did you remove the echo?
Why do you redirect stderr of chflags to /dev/null?
Why did you change the removal logic?

The way it was before:
  - rm (without -i if requested)
  - if rm fails do a chflags and rm again (bug: if user says no in the  
interactive mode, the chlags is done regardless)
  - tell the user about the stuff we do (removing flags)
  - it aborts on a failure of the second rm (AFAIR)

The way it is now:
  - for every file do a chflags without notifying the user, don't tell  
about problems
  - rm (without -i if requested)
  - bug(?): ${DESTDIR} in the rm line
  - doesn't abort on rm failure
  - has the same bug that it chflags even if the user doesn't want to  
rm the file

Before it was possible for the user to readd the flags, now the user  
doesn't know about this. I also worry about the abort on failure part  
which does not exist anymore. The last part was done on purpose, the  
former part was nice to have (because of the bug) and the printing of  
what is going on in this part was on purpose.

Bye,
Alexander.

-- 
We read to say that we have read.

http://www.Leidinger.net    Alexander @ Leidinger.net: PGP ID = B0063FE7
http://www.FreeBSD.org       netchild @ FreeBSD.org  : PGP ID = 72077137