cvs commit: src/etc network.subr

[Mike Makonnen]

On Thu, Mar 29, 2007 at 10:55:34AM +0000, Andrey A. Chernov wrote:
> ache        2007-03-29 10:55:34 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     etc                  network.subr 
>   Log:
>   Fix get_if_var() with 3 args (i.e. with default)
>   
>   All xxx_<ifname> flags are set to empty strings automatically earlier so
>   eval echo \${${prefix}${_if}${suffix}-${_default}}
>   not substitute the default but return just the empty string.
>   Fix it using
>   eval echo \${${prefix}${_if}${suffix}:-${_default}}
>   (i.e. treat empty strings as unset)
>   
>   The bug manifistates itself with the following warning from checkyesno():
>   /etc/rc.d/dhclient: WARNING: $background_dhclient is not set properly -
>   see rc.conf(5)
>   
>   Revision  Changes    Path
>   1.178     +1 -1      src/etc/network.subr

Please back this out.

Your change doesn't fix the bug. It only hides it. The bug was fixed in
rc.d/dhclient v1.28. 

Cheers.
-- 
Mike Makonnen  | GPG-KEY: http://www.identd.net/~mtm/mtm.asc
mtm at identd.net | Fingerprint: AC7B 5672 2D11 F4D0 EBF8  5279 5359 2B82 7CD4 1F55
mtm at FreeBSD.Org| FreeBSD - Unleash the Daemon !