cvs commit: src/lib/libufs type.c

[Pawel Jakub Dawidek]

On Fri, Mar 16, 2007 at 03:13:29AM +0000, Pawel Jakub Dawidek wrote:
> pjd         2007-03-16 03:13:29 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     lib/libufs           type.c 
>   Log:
>   The ufs_disk_fillout(3) can take special device name (with or without /dev/
>   prefix) as an argument and mount point path. At the end it has to find
>   device name file system is stored on, which means when mount point path is
>   given, it tries to look into /etc/fstab and find special device
>   corresponding to the given mount point. This is not perfect, because it
>   doesn't handle the case when file system is mounted by hand and mount point
>   is given as an argument.
>   
>   I found this problem while trying to use snapinfo(8), which passes mount
>   points to the ufs_disk_fillout(3) function, but I had file system mounted
>   manually, so snapinfo(8) was exiting with the error below:
>   
>           ufs_disk_fillout: No such file or directory
>   
>   I modified libufs(3) to handle those arguments (the order is important):
>   
>   1. special device with /dev/ prefix
>   2. special device without /dev/ prefix
>   3. mount point listed in /etc/fstab, directory exists
>   4. mount point listed in /etc/fstab, directory doesn't exist
>   5. mount point of a file system mounted by hand

In my opinion, when mount point is given, it should always just use
statfs(2) and don't touch /etc/fstab, but I didn't want to change the
current behaviour. Juli, do you have an opinion about this?

-- 
Pawel Jakub Dawidek                       http://www.wheel.pl
pjd at FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20070316/75e5d0c9/attachment.pgp