cvs commit: src/sys/dev/usb ukbd.c

Wilko Bulte wb at freebie.xs4all.nl
Sat Jun 16 20:22:35 UTC 2007


On Sat, Jun 16, 2007 at 10:14:14PM +0200, Erwin Lansing wrote..
> On Sat, Jun 16, 2007 at 10:01:17PM +0200, Wilko Bulte wrote:
> > On Sat, Jun 16, 2007 at 01:27:21PM -0600, Scott Long wrote..
> > > Wilko Bulte wrote:
> > > > wilko       2007-06-16 19:20:02 UTC
> > > > 
> > > >   FreeBSD src repository
> > > > 
> > > >   Modified files:
> > > >     sys/dev/usb          ukbd.c 
> > > >   Log:
> > > >   Per request (to core) by the person refered to in the comment.
> > > >   
> > > >   Revision  Changes    Path
> > > >   1.65      +0 -2      src/sys/dev/usb/ukbd.c
> > > 
> > > This commit message makes no sense.
> > 
> > I removed the 2 lines with the guys name/email address.
> > 
> Which wasn't clear from the commit message.  One needs to look up the
> diff to find out *what* has happened while the commit message only
> contains *why* it happened.  The commit message should include both.
> 
> "Remove comment per request (to core) from the person mentioned in it"

Yeah yeah... I do make mistakes too, ok?

-- 
Wilko Bulte				wilko at FreeBSD.org


More information about the cvs-src mailing list