cvs commit: src/sys/dev/nfe if_nfe.c if_nfereg.h

[Pyun YongHyeon]

On Tue, Jun 12, 2007 at 07:38:20PM +0900, To Andrew Gallatin wrote:
 > On Tue, Jun 12, 2007 at 06:05:21AM -0400, Andrew Gallatin wrote:
 >  > Pyun YongHyeon [yongari at FreeBSD.org] wrote:
 >  > > yongari     2007-06-12 02:35:01 UTC
 >  > > 
 >  > >   FreeBSD src repository
 >  > > 
 >  > >   Modified files:
 >  > >     sys/dev/nfe          if_nfe.c if_nfereg.h 
 >  > >   Log:
 >  > >   Increase a maximum segment size of DMA to 4096. Previously it used
 >  > >   MCLBYTES for the segment size but it used too many Tx descriptors in
 >  > >   TSO case.
 >  > >   While I'm here adjust maximum size of the sum of all segment lengths
 >  > >   in a given DMA mapping to 65535, the maximum size, in bytes, of a IP
 >  > 
 >  > Can't it actually be 65535 + link layer headers?  Eg, up to
 >  > 65535 + 14 or 65535 + 18?
 >  > 
 > 
 > Oops, you're right. It should be 65535 + sizeof(struct ether_vlan_header).
 > Thanks for pointing out! :)
 > 

I've checked TSO enabled drivers in tree. It seems that the following
drivers also have the same bug. CCed to maintainers.
bce(4), cxgb(4) and em(4).

-- 
Regards,
Pyun YongHyeon