cvs commit: src/sys/geom/eli g_eli.c

[Pawel Jakub Dawidek]

On Mon, Jan 29, 2007 at 10:07:24AM -0800, Nate Lawson wrote:
> Pawel Jakub Dawidek wrote:
> >Hmm, I thought that cold is zeroed before smp_started is set?
> 
> I don't think that's guaranteed.  Besides, there's an easier way to fix your problem.  Instead of calling kthread_create() from your geom create routine directly, queue a 
> stub request on the thread taskqueue to call kthread_create().
> 
> For example, see sys/dev/acpica/acpi_acad.c.  We call this from attach()    and then the system thread only runs and then calls acpi_acad_init() once all CPUs are 
> initialized.  See sys/sys/taskqueue.h for how to add a task to the system thread taskqueue:
> 
> taskqueue_enqueue(taskqueue_thread, &task);

If we want to fix it better, I think GEOM should start (tasting at
least) after all CPUs are online.

-- 
Pawel Jakub Dawidek                       http://www.wheel.pl
pjd at FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20070129/d2eb1ab7/attachment.pgp