cvs commit: src/sbin/ifconfig ifconfig.8 ifmedia.c

[Sam Leffler]

Marius Strobl wrote:
> On Sun, Jan 21, 2007 at 12:03:08PM -0800, Sam Leffler wrote:
>> Marius Strobl wrote:
>>> marius      2007-01-20 00:56:49 UTC
>>>
>>>   FreeBSD src repository
>>>
>>>   Modified files:
>>>     sbin/ifconfig        ifconfig.8 ifmedia.c 
>>>   Log:
>>>   - Display the media instance numbers and allow the user to set the active
>>>     one. This is based on NetBSD but unlike NetBSD this implementation prints
>>>     the instance number for all media instances and doesn't skip it for the
>>>     first one as I don't see a reason to suppress it except for the vague
>>>     reason to preserve the output for single-instance configurations.
>>>   - Fix some whitespace nits.
>> This overflows 80 cols for wireless devices.
> 
> I'm sorry about that.
> 
>> I suspect the information
>> is meaningless to most folks and can be safely hidden under the -v option.
>>
>> Alternatively we can take an axe to the media reporting for 802.11
>> devices.  It's pretty lame in it's present form.
>>
> 
> Well, I think that the active media instance is equally interesting
> to the media type so I'd opt for the latter but I'm certainly biased
> as I've a bunch of different NICs that use more than one PHY...
> For 802.11 devices does the listing of the supported media also
> overflow 80 cols or is just the line regarding the status of the
> active media?
> Would it still overflow when shortening "instance" to "inst"?
>

I have many nics; none w/ multiple PHY's.  I suggest you are in the
minority and printing it only when non-zero or verbose would resolve this.

	Sam