cvs commit: src/sys/kern kern_subr.c src/sys/sys systm.h
src/share/man/man9 Makefile hashinit.9
Randall Stewart
rrs at cisco.com
Mon Jan 15 19:39:27 UTC 2007
Max Laier wrote:
> On Monday 15 January 2007 16:06, Randall Stewart wrote:
> This breaks the tinderbox:
>> /src/sys/kern/kern_subr.c: In function `hashinit_flags':
>> /src/sys/kern/kern_subr.c:375: warning: suggest parentheses around
>> comparison in operand of | *** Error code 1
Yeah, it was the one thing that Robert had me add amongst
some other spacing issues. And of course I had
already did my make universe on the old version :-0
I have a patch for it.. but am waiting for approval from
George :-)
>
> and why are we useing new flags, btw? Can't we just pass down the normal
> malloc flags? I seem to remember that we do that in a couple of places
> already.
>
Well... I was game to either method.. I think the general
thought was that there may be OTHER non-memory flags
that we direct at hash-init someday.. and having them
not locked to memory was a good thing..
Robert might care to comment on this one .. of course
it can always be changed to be just the memory flags too :-)
R
--
Randall Stewart
NSSTG - Cisco Systems Inc.
803-345-0369 <or> 803-317-4952 (cell)
More information about the cvs-src
mailing list