cvs commit: src/sys/dev/usb umass.c

[Daniel O'Connor]

On Wednesday 28 February 2007 09:03, Warner Losh wrote:
>   Create a new quirk READ_CAPACITY_OFFBY1 and add a quirk for the
>   SanDISK ImageMate that I have that suffers from this problem (the
>   SDDR-31).  It intercepts the READ_CAPACITY response and adjusts it
>   from number of sectors to max sector for devices with this quirk.
>
>   Reading the Linux source suggests that there are a host of
>   other devices with this issue, including iPods and some popular
>   cameras.  I've not added quirks for them, since I don't have the
>   devices in front of me to test.

Couldn't you automatically test for this? ie try and read the last sector.

Obviously if there is a real error in the last sector you'd get a bogus result 
but I don't think that is likely to be very common :)

-- 
Daniel O'Connor software and network engineer
for Genesis Software - http://www.gsoft.com.au
"The nice thing about standards is that there
are so many of them to choose from."
  -- Andrew Tanenbaum
GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20070228/2ddda85f/attachment.pgp