cvs commit: src/sys/i386/i386 db_trace.c

[John Baldwin]

On Tuesday 20 February 2007 09:40, Kostik Belousov wrote:
> On Mon, Feb 19, 2007 at 06:49:53PM -0500, John Baldwin wrote:
> > On Monday 19 February 2007 05:57, Konstantin Belousov wrote:
> > > kib         2007-02-19 10:57:48 UTC
> > > 
> > >   FreeBSD src repository
> > > 
> > >   Modified files:
> > >     sys/i386/i386        db_trace.c 
> > >   Log:
> > >   Unbreak ddb stepping over special frames after the following commit:
> > 
> > amd64 might need the same fix, and kgdb needs to be updated for both as
> > well if it hasn't been already.
> I doubt it. Register calling conventions for amd64 made the same change 
> for this architecture to look like
> 	movq	%rsp, %rdi
> thus not modifying stack frame layout. Could someone with amd64 current box
> confirm/deny this ?

Ah, ok, had wondered about that.

> Kgdb is more involved. I think that some compatibility stuff needed there,
> to be able to step over both old and new kind of frames.

Yes, it will have to use the nearest __FreeBSD_version by checking the
osreldate variable from the core dump.

-- 
John Baldwin