cvs commit: src/usr.sbin/sysinstall main.c

[Ken Smith]

On Fri, 2007-12-28 at 05:08 +0000, Ken Smith wrote:
> kensmith    2007-12-28 05:08:54 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     usr.sbin/sysinstall  main.c 
>   Log:
>   The limit on datasize in the install environment is 128M.  That's a bit
>   too small for today's standards.  While loading packages sysinstall
>   blows past this by a LOT but I think (hope...) that's caused by other
>   bugs.  I'll look more into why sysinstall's memory use has gotten so
>   out of control as it loads packages but independent of that there really
>   is no reason to leave the limits on datasize and stacksize in place.  And
>   they can cause problems for some of the things "modern packages" might
>   be doing via pkg_add which gets run by sysinstall and would inherit the
>   limits.
>   
>   Another insta-MFC probably coming, this is holding up 6.3-RC2.  Sysinstall's
>   memory use is so out of control it blows past the current limit before it
>   finishes loading either of the meta-packages kde or gnome...
>   
>   Revision  Changes    Path
>   1.78      +10 -0     src/usr.sbin/sysinstall/main.c

*&()(*&^$#@!!!!!!!  Argh!!!!!!

Sigh...  Ok, I feel a *little* better...  Without this patch the way
things are now loading either kde or gnome during the initial install is
enough for the install to end quite abruptly complaining that init
disappeared (sysinstall runs as init during installs).

This is hopefully just a band-aid but while discussing this Kris
mentioned the 128M limit could cause some pkg_add based stuff problems
now-a-days so I don't feel too bad removing these limits.

That said, sysinstall's memory usage becomes completely insane as it
loads packages - I'll start trying to find out what's really causing it
to bloat.  Before now I really didn't have a concrete idea what was
causing the installs to terminate that way (the sysinstall environment
is a bit hostile to work in, and having it blow up so spectacularly that
its init was gone wasn't an overly helpful clue...).

To give you a feel for what I mean by "insane" if you install kde,
gnome, and a handful of other packages the sysinstall process bloats to
around 610Mb size...

-- 
                                                Ken Smith
- From there to here, from here to      |       kensmith at cse.buffalo.edu
  there, funny things are everywhere.   |
                      - Theodore Geisel |

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20071228/01de7275/attachment.pgp