cvs commit: src/sys/i386/i386 trap.c src/sys/amd64/amd64 trap.c

[Kostik Belousov]

On Tue, Dec 04, 2007 at 05:39:24PM -0800, Xin LI wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> By the way, I think the comment "always SIGSEGV mode" should be "POSIX
> mode", as it is defined POSIX behavior, but that is not a big deal, though.
It is not trully POSIX mode, as was pointed out (to me) before. POSIXyzing
it would be a future project. For now, it would delay an already late
release.

About your patch: I would answer the same as to the Frank:
I do not like #ifdefs;
it misses the (non-existing) option for compatibility with early 7-CURRENT.

Also, it would provide quite non-obvious change in the behaviour. Usually,
COMPAT_XXX turns off the features, so you simply cannot execute something
without proper COMPAT_XXX. There, you would get wrong run-time behaviour.
> 
> Cheers,
> - --
> Xin LI <delphij at delphij.net>	http://www.delphij.net/
> FreeBSD - The Power to Serve!
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.4 (FreeBSD)
> 
> iD8DBQFHVgFMhcUczkLqiksRAg0HAJ4qBG5GrBLgp4Qi96DhJU7t49KYIwCdF/W4
> CAelBTWPXSrE4jrq9lYpb74=
> =kZj/
> -----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20071205/2f373fa7/attachment.pgp