Giving in to Coverity (was: cvs commit: src/sys/netgraph/bluetooth/l2cap ng_l2cap_cmds.c)

[Greg 'groggy' Lehey]

On Thursday, 29 March 2007 at 13:36:31 +0200, Alexander Leidinger wrote:
> Quoting Andrew Thompson <thompsa at freebsd.org> (from Thu, 29 Mar 2007
> 13:52:12 +1200):
>
>> On Thu, Mar 29, 2007 at 10:58:34AM +0930, Greg 'groggy' Lehey wrote:
>>> On Wednesday, 28 March 2007 at 21:25:56 +0000, Maksim Yevmenkin wrote:
>>>> emax        2007-03-28 21:25:56 UTC
>>>>
>>>>   FreeBSD src repository
>>>>
>>>>   Modified files:
>>>>     sys/netgraph/bluetooth/l2cap ng_l2cap_cmds.c
>>>>   Log:
>>>>   Try to silence Coverity by adding (void) in front of function call.
>>>>   Also add a comment, explaining why return value is not being checked.
>>>
>>> I hope Coverity isn't going to force us to add unnecessary casts to
>>> function calls.
>>
>> Well no, you can always silence Coverity by just marking it as a false
>> bug.
>
> Maxim and me discussed this briefly before this commit.
>
> ...
>
> The cast does not obfuscate the code, doesn't make it harder to read ...

I've dropped the rest of your argumentation, because I don't disagree
with it, but I do think that unnecessary casts cause (minor)
obfuscation and make it (fractionally) more difficult to read.

My concern is that we shouldn't compromise our style because of bugs
in program checkers.  I understand that there are alternatives, like
flagging it for Coverity as "OK", and I'd expect that to be the
preferable solution.  But I'm not the guardian of style, so I'll let
others decide on this if they care.

True story: the use of parentheses around a return value is because it
used to be required by an old version of the C compiler.  When was the
compiler problem resolved?  About January 1973.  But the parentheses
are still there, even enshrined in style(9), because our grandfathers
did it that way.

Greg
--
See complete headers for address and phone numbers.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20070402/56bc384a/attachment.pgp