cvs commit: src/etc/rc.d mountcritlocal mountlate src/sbin/mount mount.8 mount.c

[SANETO Takanori]

I understand that the code around invoking external mount commands is
quite different between -CURRENT and RELENG_6.
I did not looked into the code but just saw commit message like "Do not
pass noauto to nmount() or external mount program." in 1.73.

What I actually did to avoid the error message I got was:

> Index: mount.c
> ===================================================================
> RCS file: /export/cvs/src/sbin/mount/mount.c,v
> retrieving revision 1.69.2.2
> diff -u -r1.69.2.2 mount.c
> --- mount.c     13 Sep 2006 08:38:49 -0000      1.69.2.2
> +++ mount.c     26 Sep 2006 09:17:25 -0000
> @@ -429,6 +429,7 @@
>                 }
>         }
>         optbuf = catopt(strdup(mntopts), options);
> +       remopt(optbuf, "late");
> 
>         if (strcmp(name, "/") == 0)
>                 flags |= MNT_UPDATE;

Can this be the correct fix for RELENG_6?

Regards,

Saneto

SANETO Takanori wrote:
> DES,
> 
> I think it affects argv for external mount commands as well as nmount.
> In fact, on RELENG_6, I got a message like "mount_smbfs: unknown option
> -o late" when I put "late" in my fstab like this:
> 
> //SANEWO at SMBHOST/SMBDRIVE  /smb/mnt1  smbfs   rw,late         0       0
> 
> Thanks,
> 
> Saneto
> 
> Dag-Erling Smørgrav wrote:
>> des at des.no (Dag-Erling Smørgrav) writes:
>>> SANETO Takanori <sanewo at ba2.so-net.ne.jp> writes:
>>>> As for mount.c, following part should be MFC'ed as well.
>>> Thanks, I don't understand how it was left out.
>> Uh, wait, it was left out for a reason: there is no equivalent code in
>> RELENG_6.  The hunk in question removes "late" from the list of
>> options passed to nmount(), which isn't used in RELENG_6.
>>
>> DES