[fbsd] cvs commit [HEAD] src/etc/rc.d jail src/etc/defaults rc.conf src/share/man/man5 rc.conf.5

[Jeremie Le Hen]

Matteo,

On Tue, May 30, 2006 at 04:20:48PM +0000, Matteo Riondato wrote:
> matteo      2006-05-30 16:20:48 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     etc/rc.d             jail 
>     etc/defaults         rc.conf 
>     share/man/man5       rc.conf.5 
>   Log:
>   Add jail_<jname>_exec_afterstart<N> rc.conf variable, where <N> is
>   1,2 and so on.
>   It specifies the command to be run as Nth after jail startup.
>   
>   sh(1)-fu by: Dario Freni
>   PR:     conf/97697
>   MFC after: 2 weeks
>   Reviewed by: ru@ (man page)

The variable name as well as the manpage is IMHO misleading.  I thought
the command was executed on the host, not inside the jail.

I daresay the name should have been something like:
jail_<jname>_jexec_afterstart<N>.  But we would have lost
name consistency with jail_<jname>_exec_start.

We should at least fix the documentation:

Index: rc.conf.5
===================================================================
RCS file: /home/ncvs/src/share/man/man5/rc.conf.5,v
retrieving revision 1.306
diff -u -p -u -r1.306 rc.conf.5
--- rc.conf.5   18 Sep 2006 15:24:20 -0000      1.306
+++ rc.conf.5   22 Sep 2006 13:47:15 -0000
@@ -3209,7 +3209,7 @@ This is the command executed at jail sta
 .It Va jail_ Ns Ao Ar jname Ac Ns Va _exec_afterstart Ns Aq Ar N
 .Pq Vt str
 Unset by default.
-This is the command run as
+This is the command run inside the jail as
 .Ar N Ns
 th command
 after jail startup, where



Thank you.  Regards,
-- 
Jeremie Le Hen
< jeremie at le-hen dot org >< ttz at chchile dot org >