cvs commit: src/contrib/top sigconv.awk src/usr.bin/top Makefile sigdesc.h

Giorgos Keramidas keramida at FreeBSD.org
Thu Nov 30 23:01:24 PST 2006


keramida    2006-12-01 07:01:19 UTC

  FreeBSD src repository (doc committer)

  Modified files:
    contrib/top          sigconv.awk 
    usr.bin/top          Makefile 
  Removed files:
    usr.bin/top          sigdesc.h 
  Log:
  The sigconv.awk script generates a sigdesc.h header file, which
  contains a sigdec[] vector of structures, but the generated output is
  missing braces around the initializer of each struct, which
  triggers warnings in WARNS=3:
  
  src/usr.bin/top/sigdesc.h:10: warning: missing braces around initializer
  src/usr.bin/top/sigdesc.h:10: warning: (near initialization for `sigdesc[0]')
  
    * Fix the sigconv.awk script to generate a header with initializers
      which look better.
  
    * Add rules to usr.bin/top/Makefile that rebuilds a new sigconv.h
      header which matches the correct signal set from the build-time
      version of `${DESTDIR}/usr/include/signal.h' (so sigconv.h doesn't
      get stale once changes are made to the header).
  
    * Remove the old sigconv.h header, now that it is autoupdated at
      build time.
  
    * Various Makefile style fixes (the committed Makefile was kindly
      submitted by Ruslan):
  
      - Reorder .PATH, PROG, SRCS and CFLAGS to match style.Makefile(5)
      - Split off the generated sources (sigdesc.h top.local.h) in an
        SRCS+= line of their own.
      - Add entries to CLEANFILES near the rules that generate the
        respective files.
      - Move the explicit rule which builds top.1 after the implicit
        rules which generate its dependencies.
  
  Reviewed by:    ru, bde
  Submitted by:   ru (Makefile)
  MFC after:      2 weeks
  
  Revision  Changes    Path
  1.2       +9 -7      src/contrib/top/sigconv.awk
  1.11      +20 -13    src/usr.bin/top/Makefile
  1.2       +0 -42     src/usr.bin/top/sigdesc.h (dead)


More information about the cvs-src mailing list