cvs commit: src/sys/security/audit audit_syscalls.c

John Baldwin jhb at freebsd.org
Mon Nov 20 18:43:17 UTC 2006


On Saturday 18 November 2006 15:59, Konstantin Belousov wrote:
> kib         2006-11-18 20:59:50 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:        (Branch: RELENG_6)
>     sys/security/audit   audit_syscalls.c 
>   Log:
>   On RELENG_6, vn_open() will drop Giant aquired for calls into
>   non-MP-safe filesystem if fdx == -1, assuming the in-kernel callers are
>   not MP-safe. On HEAD, vn_open() after rev. 1.240 of sys/kern/vfs_vnops.c
>   would keep the Giant locked when the MPSAFE flag is given.
>   
>   The difference in the API caused the auditctl() syscall code to try to
>   unlock non-locked Giant for non-MP-safe filesystems, for instance, UFS
>   when QUOTA is compiled in.
>   
>   This is direct commit to RELENG_6 to accomodate for RELENG_6' vn_open().
>   
>   Reported by:    Steve Wills (steve at stevenwills com)
>   Reviewed by:    rwatson
>   Approved by:    re (bmah)
>   X-MFC to RELENG_6_2 after:      3 days

Should probably MFC the vn_open() fixes to be honest, but that can be post 
6.2.

-- 
John Baldwin


More information about the cvs-src mailing list