cvs commit: src/sys/amd64/conf DEFAULTS src/sys/i386/conf DEFAULTS src/sys/ia64/conf DEFAULTS src/sys/pc98/conf DEFAULTS src/sys/powerpc/conf DEFAULTS src/sys/sparc64/conf DEFAULTS src/sys/sparc64/sparc64 machdep.c src/sys/sun4v/conf DEFAULTS

[Sam Leffler]

John Birrell wrote:
> On Sat, Nov 04, 2006 at 10:11:56AM +0100, Simon L. Nielsen wrote:
>> Why isn't it just in GENERIC so people can easily disable it if they
>> like?  I thought DEFAULTS was just meant for things which caused users
>> pain (and people answering support mails...) if they accidentally
>> missed the option?  I don't really see DTrace falling in that
>> category.
> 
> I added it to DEFAULTS so that it would be available automatically for
> people who didn't know that they want it. 8-)
> 
> Adding it to GENERIC doesn't cover the people who have their own
> kernel configs. And they can still disable it in GENERIC or whatever
> config they are using just as easily as they could add it.
> 
> The point is that there is negligible run-time impact and only a
> small increase in code size to have it enabled. Remember it's only
> the hooks and a few support functions. The guts of DTrace is in the
> 'dtrace' kernel module (and the associated providers) which still
> have to be loaded as modules.

Like he said, this is contrary to the purpose of DEFAULTS.  You are
forcing policy on people.  Please put it in GENERIC where it belongs.

	Sam