cvs commit: src/sys/ufs/ffs ffs_vfsops.c

[Peter Jeremy]

On Tue, 2006-May-30 08:12:10 +0400, Andrey Chernov wrote:
>On Mon, May 29, 2006 at 11:45:31PM -0400, Craig Rodrigues wrote:
>
>> +		if (strcmp(argv[i], "ro") == 0 &&
>> +		    strcmp(argv[i-1], "-o") == 0) {
>> +			return 1;
>
>It looks like hack. There is comma separated list for -o needs to be fully 
>parsed, f.e. '-o acls,ro'

There's already code in mount(8) that understands how to merge conflicting
option lists (from the command line and fstab).  It needs to be taught
that:
- -r, ro and norw are equivalent
- rw and noro are equivalent
- -r/ro/norw and rw/noro are complementary.

-- 
Peter Jeremy