cvs commit: src/lib/libthr Makefile

[Dag-Erling Smørgrav]

des at des.no (Dag-Erling Smørgrav) writes:
> David Xu <davidxu at FreeBSD.org> writes:
> >   Log:
> >   Comment out -g compiler option, found by 'FreeBSD Build Options Survey'.
> You should simply remove it (users who want it can define DEBUG_FLAGS
> in make.conf), and define WARNS instead of adding -Wall to CFLAGS.

...especially in light of the following:

cc -O2 -pipe -march=pentium4 -DPTHREAD_KERNEL -I/usr/src/lib/libthr/../libc/include -I/usr/src/lib/libthr/thread  -I/usr/src/lib/libthr/../../include -I/usr/src/lib/libthr/arch/i386/include -I/usr/src/lib/libthr/sys -I/usr/src/lib/libthr/../../libexec/rtld-elf -I/usr/src/lib/libthr/../../libexec/rtld-elf/i386 -I/usr/src/lib/libthr/../libthread_db -Winline -D_PTHREADS_INVARIANTS -g -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wunused-parameter -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -c /usr/src/lib/libthr/arch/i386/i386/pthread_md.c
cc -O2 -pipe -march=pentium4 -DPTHREAD_KERNEL -I/usr/src/lib/libthr/../libc/include -I/usr/src/lib/libthr/thread  -I/usr/src/lib/libthr/../../include -I/usr/src/lib/libthr/arch/i386/include -I/usr/src/lib/libthr/sys -I/usr/src/lib/libthr/../../libexec/rtld-elf -I/usr/src/lib/libthr/../../libexec/rtld-elf/i386 -I/usr/src/lib/libthr/../libthread_db -Winline -D_PTHREADS_INVARIANTS -g -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wunused-parameter -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -c /usr/src/lib/libthr/sys/thr_error.c
In file included from /usr/src/lib/libthr/thread/thr_private.h:47,
                 from /usr/src/lib/libthr/sys/thr_error.c:40:
/usr/src/lib/libthr/../../include/stdio.h:415: warning: redundant redeclaration of '__isthreaded'
/usr/src/lib/libthr/../libc/include/libc_private.h:46: warning: previous declaration of '__isthreaded' was here
In file included from /usr/src/lib/libthr/thread/thr_umtx.h:32,
                 from /usr/src/lib/libthr/thread/thr_private.h:59,
                 from /usr/src/lib/libthr/sys/thr_error.c:40:
/usr/include/sys/umtx.h: In function `umtx_lock':
/usr/include/sys/umtx.h:83: warning: passing arg 1 of `atomic_cmpset_int' from incompatible pointer type
/usr/include/sys/umtx.h:83: warning: passing arg 2 of `atomic_cmpset_int' makes integer from pointer without a cast
/usr/include/sys/umtx.h:83: warning: passing arg 3 of `atomic_cmpset_int' makes integer from pointer without a cast
/usr/include/sys/umtx.h: In function `umtx_trylock':
/usr/include/sys/umtx.h:93: warning: passing arg 1 of `atomic_cmpset_int' from incompatible pointer type
/usr/include/sys/umtx.h:93: warning: passing arg 2 of `atomic_cmpset_int' makes integer from pointer without a cast
/usr/include/sys/umtx.h:93: warning: passing arg 3 of `atomic_cmpset_int' makes integer from pointer without a cast
/usr/include/sys/umtx.h: In function `umtx_timedlock':
/usr/include/sys/umtx.h:102: warning: passing arg 1 of `atomic_cmpset_int' from incompatible pointer type
/usr/include/sys/umtx.h:102: warning: passing arg 2 of `atomic_cmpset_int' makes integer from pointer without a cast
/usr/include/sys/umtx.h:102: warning: passing arg 3 of `atomic_cmpset_int' makes integer from pointer without a cast
/usr/include/sys/umtx.h:103: warning: cast discards qualifiers from pointer target type
/usr/include/sys/umtx.h: In function `umtx_unlock':
/usr/include/sys/umtx.h:112: warning: passing arg 1 of `atomic_cmpset_int' from incompatible pointer type
/usr/include/sys/umtx.h:112: warning: passing arg 2 of `atomic_cmpset_int' makes integer from pointer without a cast
/usr/include/sys/umtx.h:112: warning: passing arg 3 of `atomic_cmpset_int' makes integer from pointer without a cast
/usr/include/sys/umtx.h: In function `umtx_wait':
/usr/include/sys/umtx.h:121: warning: cast discards qualifiers from pointer target type
In file included from /usr/src/lib/libthr/sys/thr_error.c:40:
/usr/src/lib/libthr/thread/thr_private.h: At top level:
/usr/src/lib/libthr/thread/thr_private.h:206: warning: function declaration isn't a prototype
/usr/src/lib/libthr/thread/thr_private.h:242: warning: function declaration isn't a prototype
/usr/src/lib/libthr/thread/thr_private.h:611: warning: redundant redeclaration of '__isthreaded'
/usr/src/lib/libthr/../../include/stdio.h:415: warning: previous declaration of '__isthreaded' was here
/usr/src/lib/libthr/thread/thr_private.h:618: warning: redundant redeclaration of '_thr_initial'
/usr/src/lib/libthr/arch/i386/include/pthread_md.h:97: warning: previous declaration of '_thr_initial' was here
*** Error code 1

Stop in /usr/src/lib/libthr.

DES
-- 
Dag-Erling Smørgrav - des at des.no