cvs commit: src/sys/amd64/linux32 linux32_sysvec.c syscalls.master src/sys/compat/linux linux_file.c linux_getcwd.c linux_ioctl.c linux_ipc.c linux_mib.c linux_misc.c linux_signal.c linux_socket.c linux_stats.c linux_sysctl.c linux_uid16.c

[Ruslan Ermilov]

Hi Alexander,

Linuxulator is still broken after my preliminary fix referenced
below, on both amd64 and alpha.  On amd64, it now stops here:

: cc -c -O2 -frename-registers -pipe -fno-strict-aliasing  -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -fformat-extensions -std=c99 -g -nostdinc -I-  -I. -I/usr/src/sys -I/usr/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000  -fno-omit-frame-pointer -mcmodel=kernel -mno-red-zone  -mfpmath=387 -mno-sse -mno-sse2 -mno-mmx -mno-3dnow  -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -Werror  /usr/src/sys/compat/linux/linux_stats.c
: /usr/src/sys/compat/linux/linux_stats.c:233: warning: "struct linux_lstat_args" declared inside parameter list
: /usr/src/sys/compat/linux/linux_stats.c:233: warning: its scope is only this definition or declaration, which is probably not what you want
: /usr/src/sys/compat/linux/linux_stats.c:234: warning: no previous prototype for 'linux_lstat'
: /usr/src/sys/compat/linux/linux_stats.c: In function `linux_lstat':
: /usr/src/sys/compat/linux/linux_stats.c:242: error: dereferencing pointer to incomplete type
: /usr/src/sys/compat/linux/linux_stats.c:245: error: dereferencing pointer to incomplete type
: *** Error code 1
: 
: Stop in /usr/obj/usr/src/sys/HAMMER.
: *** Error code 1

On alpha/LINT, it will break similarly, because you didn't provide
support for them.

You obviously didn't build test your change on anything except i386,
or you would notice that inclusion of "opt_compat.h" is needed so
the sources can see the COMPAT_LINUX32/COMPAT_IA32 options.

On Sun, Mar 19, 2006 at 11:10:33AM +0000, Ruslan Ermilov wrote:
> ru          2006-03-19 11:10:33 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/amd64/linux32    linux32_sysvec.c syscalls.master 
>     sys/compat/linux     linux_file.c linux_getcwd.c linux_ioctl.c 
>                          linux_ipc.c linux_mib.c linux_misc.c 
>                          linux_signal.c linux_socket.c 
>                          linux_stats.c linux_sysctl.c 
>                          linux_uid16.c 
>   Log:
>   Unbreak COMPAT_LINUX32 option support on amd64.
>   
>   Broken by:      netchild
>   
>   Revision  Changes    Path
>   1.17      +1 -0      src/sys/amd64/linux32/linux32_sysvec.c
>   1.7       +1 -0      src/sys/amd64/linux32/syscalls.master
>   1.94      +1 -0      src/sys/compat/linux/linux_file.c
>   1.24      +1 -0      src/sys/compat/linux/linux_getcwd.c
>   1.135     +2 -0      src/sys/compat/linux/linux_ioctl.c
>   1.46      +2 -0      src/sys/compat/linux/linux_ipc.c
>   1.26      +2 -0      src/sys/compat/linux/linux_mib.c
>   1.175     +1 -0      src/sys/compat/linux/linux_misc.c
>   1.54      +2 -0      src/sys/compat/linux/linux_signal.c
>   1.65      +1 -0      src/sys/compat/linux/linux_socket.c
>   1.78      +1 -0      src/sys/compat/linux/linux_stats.c
>   1.17      +2 -0      src/sys/compat/linux/linux_sysctl.c
>   1.19      +2 -0      src/sys/compat/linux/linux_uid16.c


Cheers,
-- 
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20060319/808c6059/attachment.pgp