cvs commit: src/sys/i386/i386 mpapic.c

[John Baldwin]

On Friday 10 March 2006 05:20 am, Yar Tikhiy wrote:
> On Thu, Mar 09, 2006 at 04:23:15PM +0000, John Baldwin wrote:
> > jhb         2006-03-09 16:23:15 UTC
> >
> >   FreeBSD src repository
> >
> >   Modified files:        (Branch: RELENG_4)
> >     sys/i386/i386        mpapic.c
> >   Log:
> >   Revert the previous change.  Even though Intel insists that the
> > behavior this change restores is wrong, it turns out the "proper" method
> > is worse in practice for existing machines.  This is probably due to the
> > fact that using fixed priority with a physical broadcast destination
> > effectively broadcasts interrupts to all CPUs.  Fixing that would require
> > a lot more work than just restoring the previous "incorrect" behavior and
> > would probably be riskier as well.
> >
> >   PR:             kern/94160
> >   Reported by:    Richard Wiwatowski rjwiwat at internode dot on dot net
> >
> >   Revision  Changes    Path
> >   1.37.2.9  +3 -3      src/sys/i386/i386/mpapic.c
>
> This problem cannot affect a kernel unless it has been built
> with "options SMP", can it?  Thanks!

Correct.  Strictly speaking it's under options APIC_IO, but on 4.x
those two options are basically tied together.

-- 
John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org