cvs commit: src/sys/net if.c if_atmsubr.c if_stf.c if_tun.c src/sys/netinet if_ether.c ip_divert.c ip_fw2.c src/sys/netinet6 in6.c in6_var.h src/sys/nfsclient bootp_subr.c nfs_diskless.c

[Yar Tikhiy]

On Fri, Jun 30, 2006 at 03:44:10PM +0400, Gleb Smirnoff wrote:
> On Thu, Jun 29, 2006 at 07:22:05PM +0000, Yar Tikhiy wrote:
> Y>   Modified files:
> Y>     sys/net              if.c if_atmsubr.c if_stf.c if_tun.c 
> Y>     sys/netinet          if_ether.c ip_divert.c ip_fw2.c 
> Y>     sys/netinet6         in6.c in6_var.h 
> Y>     sys/nfsclient        bootp_subr.c nfs_diskless.c 
> Y>   Log:
> Y>   There is a consensus that ifaddr.ifa_addr should never be NULL,
> Y>   except in places dealing with ifaddr creation or destruction; and
> Y>   in such special places incomplete ifaddrs should never be linked
> Y>   to system-wide data structures.  Therefore we can eliminate all the
> Y>   superfluous checks for "ifa->ifa_addr != NULL" and get ready
> Y>   to the system crashing honestly instead of masking possible bugs.
> Y>   
> Y>   Suggested by:   glebius, jhb, ru
> 
> I think this can also close few reports from Coverity.

The only report I was aware of was CID 448.

-- 
Yar