cvs commit: src/sys/kern uipc_socket2.c src/sys/sys socketvar.h

[Robert Watson]

rwatson     2006-06-28 14:33:47 UTC

  FreeBSD src repository

  Modified files:        (Branch: RELENG_6)
    sys/kern             uipc_socket2.c 
    sys/sys              socketvar.h 
  Log:
  Merge uipc_socket2.c:1.158 and socketvar.h:1.150 from HEAD to RELENG_6:
  
    Remove sbinsertoob(), sbinsertoob_locked().  They violate (and have
    basically always violated) invariannts of soreceive(), which assume
    that the first mbuf pointer in a receive socket buffer can't change
    while the SB_LOCK sleepable lock is held on the socket buffer,
    which is precisely what these functions do.  No current protocols
    invoke these functions, and removing them will help discourage them
    from ever being used.  I should have removed them years ago, but
    lost track of it.
  
    Prodded almost by accident by:  peter
  
  Revision   Changes    Path
  1.147.2.5  +0 -64     src/sys/kern/uipc_socket2.c
  1.141.2.1  +0 -2      src/sys/sys/socketvar.h