cvs commit: src/sys/ufs/ufs ufs_vnops.c

[Tom Rhodes]

On Thu, 1 Jun 2006 10:01:27 +0000
Alexey Dokuchaev <danfe at FreeBSD.org> wrote:

> On Thu, Jun 01, 2006 at 10:49:50AM +0100, Ceri Davies wrote:
> > On Thu, Jun 01, 2006 at 12:05:23PM +0930, Greg 'groggy' Lehey wrote:
> > > On Wednesday, 31 May 2006 at 13:15:29 +0000, Maxim Konovalov wrote:
> > > > maxim       2006-05-31 13:15:29 UTC
> > > >
> > > >   FreeBSD src repository
> > > >
> > > >   Modified files:
> > > >     sys/ufs/ufs          ufs_vnops.c
> > > >   Log:
> > > >   o According to POSIX, the result of ftruncate(2) is unspecified
> > > >   for file types other than VREG, VDIR and shared memory objects.
> > > >   We already handle VREG, VLNK and VDIR cases.  Silently ignore
> > > >
> > > >   Revision  Changes    Path
> > > >   1.276     +22 -4     src/sys/ufs/ufs/ufs_vnops.c
> > > 
> > > Is this worth a man page update?
> > 
> > Undoubtedly.  Does the attached look like enough?  I'm not sure if we
> > want to add a STANDARDS section for this when it's valid behaviour.
> > 
> > Ceri
> > -- 
> > That must be wonderful!  I don't understand it at all.
> >                                                   -- Moliere
> 
> > Index: src/lib/libc/sys/truncate.2
> > ===================================================================
> > RCS file: /home/ncvs/src/lib/libc/sys/truncate.2,v
> > retrieving revision 1.17
> > diff -u -r1.17 truncate.2
> > --- src/lib/libc/sys/truncate.2	20 Jan 2005 09:17:05 -0000	1.17
> > +++ src/lib/libc/sys/truncate.2	1 Jun 2006 09:47:19 -0000
> > @@ -32,7 +32,7 @@
> >  .\"     @(#)truncate.2	8.1 (Berkeley) 6/4/93
> >  .\" $FreeBSD: src/lib/libc/sys/truncate.2,v 1.17 2005/01/20 09:17:05 ru Exp $
> >  .\"
> > -.Dd June 4, 1993
> > +.Dd June 1, 2006
> >  .Dt TRUNCATE 2
> >  .Os
> >  .Sh NAME
> > @@ -69,6 +69,10 @@
> >  the file must be open for writing.
> >  .Sh RETURN VALUES
> >  .Rv -std
> > +If the file to be modified is not a directory or
> > +a regular file, the
> > +.Fn truncate
> > +call will return the value 0.
> 
> Doesn't "value of 0" sound better?

I like "zero" - we should see what core thinks first though.

-- 
Tom Rhodes