cvs commit: src/sys/compat/svr4 svr4_socket.c svr4_socket.h svr4_stream.c svr4_sysvec.c src/sys/dev/streams streams.c

[John Baldwin]

jhb         2006-07-21 20:40:13 UTC

  FreeBSD src repository

  Modified files:
    sys/compat/svr4      svr4_socket.c svr4_socket.h svr4_stream.c 
                         svr4_sysvec.c 
    sys/dev/streams      streams.c 
  Log:
  Clean up the svr4 socket cache and streams code some to make it more easily
  locked.
  - Move all the svr4 socket cache code into svr4_socket.c, specifically
    move svr4_delete_socket() over from streams.c.  Make the socket cache
    entry structure and svr4_head private to svr4_socket.c as a result.
  - Add a mutex to protect the svr4 socket cache.
  - Change svr4_find_socket() to copy the sockaddr_un struct into a
    caller-supplied sockaddr_un rather than giving the caller a pointer to
    our internal one.  This removes the one case where code outside of
    svr4_socket.c could access data in the cache.
  - Add an eventhandler for process_exit and process_exec to purge the cache
    of any entries for the exiting or execing process.
  - Add methods to init and destroy the socket cache and call them from the
    svr4 ABI module's event handler.
  - Conditionally grab Giant around socreate() in streamsopen().
  - Use fdclose() instead of inlining it in streamsopen() when handling
    socreate() failure.
  - Only allocate a stream structure and attach it to a socket in
    streamsopen().  Previously, if a svr4 program performed a stream
    operation on an arbitrary socket not opened via the streams device,
    we would attach streams state data to it and change f_ops of the
    associated struct file while it was in use.  The latter was especially
    not safe, and if a program wants a stream object it should open it via
    the streams device anyway.
  - Don't bother locking so_emuldata in the streams code now that we only
    touch it right after creating a socket (in streamsopen()) or when
    tearing it down when the file is closed.
  - Remove D_NEEDGIANT from the streams device as it is no longer needed.
  
  Revision  Changes    Path
  1.27      +90 -13    src/sys/compat/svr4/svr4_socket.c
  1.10      +6 -17     src/sys/compat/svr4/svr4_socket.h
  1.59      +2 -4      src/sys/compat/svr4/svr4_stream.c
  1.42      +12 -6     src/sys/compat/svr4/svr4_sysvec.c
  1.54      +29 -75    src/sys/dev/streams/streams.c