cvs commit: src/sys/dev/mii acphy.c amphy.c bmtphy.c brgphy.c ciphy.c e1000phy.c exphy.c inphy.c lxtphy.c mlphy.c nsgphy.c nsphy.c pnaphy.c qsphy.c rgephy.c rlphy.c ruephy.c tdkphy.c tlphy.c ukphy.c xmphy.c

[Nate Lawson]

Pyun YongHyeon wrote:
> yongari     2006-07-03 02:53:40 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/dev/mii          acphy.c amphy.c bmtphy.c brgphy.c ciphy.c 
>                          e1000phy.c exphy.c inphy.c lxtphy.c 
>                          mlphy.c nsgphy.c nsphy.c pnaphy.c qsphy.c 
>                          rgephy.c rlphy.c ruephy.c tdkphy.c 
>                          tlphy.c ukphy.c xmphy.c 
>   Log:
>   Replace hard-coded magic constants to system defined constants
>   (BUS_PROBE_DEFAULT, BUS_PROBE_GENERIC etc).
>   There is no functional changes.
>   
>   Reviewed by:    oleg, scottl

Actually, there are functional changes.  Whether those changes are ok or 
not, I don't know.

> --- src/sys/dev/mii/acphy.c:1.17	Fri Sep 30 19:39:27 2005
> +++ src/sys/dev/mii/acphy.c	Mon Jul  3 02:53:39 2006
> @@ -132,7 +132,7 @@
>  	} else 
>  		return (ENXIO);
>  
> -	return (0);
> +	return (BUS_PROBE_DEFAULT);
>  }
>  
>  static int

This means probe() will be called multiple times to allow bidding for 
the device.  Is that ok for this and other devices?

-- 
Nate