cvs commit: src/sys/kern kern_malloc.c

[Harald Schmalzbauer]

Am Mittwoch, 28. Dezember 2005 02:53 CEST schrieb Pawel Jakub Dawidek:
> pjd         2005-12-28 01:53:13 UTC
>
>   FreeBSD src repository
>
>   Modified files:
>     sys/kern             kern_malloc.c
>   Log:
>   In realloc(9), determine size of the original block based on
>   UMA_SLAB_MALLOC flag.
>   In some circumstances (I observed it when I was doing a lot of
> reallocs) UMA_SLAB_MALLOC can be set even if us_keg != NULL.
>
>   If this is the case we have wonderful, silent data corruption, because
> less data is copied to the newly allocated region than should be.
>
>   I'm not sure when this bug was introduced, it could be there
> undetected for years now, as we don't have a lot of realloc(9) consumers
> and it was hard to reproduce it...
>   ...but what I know for sure, is that I don't want to know who
> introduce the bug:) It took me two/three days to track it down (of
> course most of the time I was looking for the bug in my own code).
>
>   Revision  Changes    Path
>   1.150     +1 -1      src/sys/kern/kern_malloc.c

Thanks for your work, I'm using it in RELENG_6 from day one without any 
impact, so perhaps it's safe to MFC?

-Harry

> _______________________________________________
> cvs-src at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/cvs-src
> To unsubscribe, send any mail to "cvs-src-unsubscribe at freebsd.org"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20060112/7613a82c/attachment.bin