cvs commit: src/sys/kern vfs_syscalls.c

[Poul-Henning Kamp]

In message <200601032158.k03LwMGP031138 at repoman.freebsd.org>, Diomidis Spinellis writes:
>dds         2006-01-03 21:58:22 UTC
>
>  FreeBSD src repository
>
>  Modified files:
>    sys/kern             vfs_syscalls.c 
>  Log:
>  Normalize the tv_usec part of the utimes(2) arguments to ensure
>  that a file's atime and mtime are only set to correct fractional
>  second values (0-999999000ns with the current interface).
>  Prior to this change users could create files with values outside
>  that range.  Moreover, on 32-bit machines tv_usec offsets larger than
>  4.3s would result in an unnormalized AND wrong timestamp value,
>  due to overflow.

I think this is wrong.  We should return EINVAL if the fractional
part is not correct.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.